Skip to content

Tidy implementation detail in gemini-cli (#28340)#28366

Closed
bglglzd wants to merge 1 commit into
google-gemini:mainfrom
bglglzd:bugfix/28340-20260712-152416
Closed

Tidy implementation detail in gemini-cli (#28340)#28366
bglglzd wants to merge 1 commit into
google-gemini:mainfrom
bglglzd:bugfix/28340-20260712-152416

Conversation

@bglglzd

@bglglzd bglglzd commented Jul 12, 2026

Copy link
Copy Markdown

Small scoped patch based on the reported behavior.

Related to #28340.

@bglglzd bglglzd requested review from a team as code owners July 12, 2026 15:24
@github-actions github-actions Bot added the size/xl An extra large PR label Jul 12, 2026
@google-cla

google-cla Bot commented Jul 12, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XL

  • Lines changed: 1777
  • Additions: +18
  • Deletions: -1759
  • Files changed: 21

@github-actions

Copy link
Copy Markdown

🛑 Action Required: Evaluation Approval

Steering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged.

Maintainers:

  1. Go to the Workflow Run Summary.
  2. Click the yellow 'Review deployments' button.
  3. Select the 'eval-gate' environment and click 'Approve'.

Once approved, the evaluation results will be posted here automatically.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor code hygiene improvements. It primarily addresses trailing whitespace in various test and evaluation files and removes several outdated SVG snapshot files, contributing to a cleaner and more maintainable codebase without introducing new features or significant behavioral changes.

Highlights

  • Whitespace Removal: Trailing whitespace was removed from several evaluation and integration test TypeScript files to improve code consistency.
  • Snapshot File Removal: Numerous SVG snapshot files related to InputPrompt and ToolConfirmationQueue UI components were removed, likely indicating an update to the snapshot testing methodology or component rendering.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs minor whitespace cleanup by removing trailing spaces in several evaluation and integration test files, including evals/automated-tool-use.eval.ts, evals/prompt_injection_mcp.eval.ts, evals/update_topic.eval.ts, and integration-tests/hooks-system.test.ts. Additionally, a series of unused SVG files representing terminal UI recordings or mockups have been deleted. There are no review comments associated with this pull request, and I have no feedback to provide.

Note: Security Review did not run due to the size of the PR.

@gemini-cli gemini-cli Bot added priority/p1 Important and should be addressed in the near term. area/core Issues related to User Interface, OS Support, Core Functionality labels Jul 12, 2026
@bglglzd bglglzd closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p1 Important and should be addressed in the near term. size/xl An extra large PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant