chore: add test of all supported BigQuery data types#17570
Draft
tswast wants to merge 6 commits into
Draft
Conversation
This should be helpful in more thorough testing of the new compiler. Towards b/527509188
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the nested_structs test dataset and schema to include a wide variety of data types (such as boolean, integers, floats, JSON, dates, timestamps, geography, and decimals) and edge cases. It also updates the nested_structs_pandas_df fixture to manually parse these types and adds a comprehensive test suite to verify their behavior. Feedback was provided regarding a potential compatibility issue with datetime.datetime.fromisoformat parsing the trailing 'Z' suffix in Python versions older than 3.11.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
|
Switching to draft until checks are green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be helpful in more thorough testing of the new compiler.
Towards b/527509188
🦕