Fix CogView3 lazy export to match the actual output class name#13951
Open
rumitvn wants to merge 1 commit into
Open
Fix CogView3 lazy export to match the actual output class name#13951rumitvn wants to merge 1 commit into
rumitvn wants to merge 1 commit into
Conversation
The lazy _import_structure advertised CogView3PlusPipelineOutput, but the class is defined as CogView3PipelineOutput in pipeline_output.py, so importing the advertised symbol raised an ImportError.
Contributor
|
Hi @rumitvn, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cogview3package advertisesCogView3PlusPipelineOutputin its lazy_import_structure, but the output class is defined asCogView3PipelineOutput(no "Plus") inpipeline_output.py. Because of the mismatch,from diffusers.pipelines.cogview3 import CogView3PlusPipelineOutputraises an ImportError.This points the lazy export at the real class name. The pipeline module already imports
CogView3PipelineOutput, and the API docs autodoc that same name, so this just brings the lazy export in line with both.The neighbouring
CogView3PlusPipelineexport is the actual pipeline class name and is intentionally left as-is — only the output-class export had the stray "Plus".Addresses Issue 1 of #13648.