ci: Sync R-CMD-check workflow; drop matrix-env plumbing from custom action - #2798
Merged
Conversation
…ction Sync .github/workflows/R-CMD-check.yaml and .github/workflows/versions-matrix/action.R from cynkratemplate (cynkra/cynkratemplate#95). The rcc-full job now applies the generic "env" field of test matrix entries to $GITHUB_ENV itself, before the custom before-install action runs, because composite actions cannot read the matrix context. The apply-to-GITHUB_ENV boilerplate and the "env" input in the custom before-install action are therefore no longer needed; IGRAPH_LIFECYCLE_ERRORS=true from the lifecycle-errors matrix entry keeps reaching the tests through the workflow-level step.
krlmlr
enabled auto-merge (squash)
July 27, 2026 18:34
Rscript tools/generate-migrations.R produces changes on the current main (pre-existing drift, most likely from the merge order of the migration refactors merged today); the rcc-smoke drift check fails on every branch until the regenerated blocks are committed. Generated code only, no manual edits.
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if fd5b37c is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was prepared with Claude Code (LLM disclosure).
Sync
.github/workflows/R-CMD-check.yamland.github/workflows/versions-matrix/action.Rfrom cynkratemplate(cynkra/cynkratemplate#95).
The claim from #2782 —
that a custom before-install action is needed
to pick up the
envfield of a test matrix entry —was accurate under the old template design,
and it applied to all template consumers, not just rigraph:
composite actions cannot read the
matrixcontext,so the workflow forwarded
matrix.envas an action input,and each repo had to apply it to
$GITHUB_ENVitself.The template's
rcc-fulljob now applies the genericenvfieldto
$GITHUB_ENVdirectly, before the custom before-install action runs,so no repo needs plumbing of its own.
The apply boilerplate and the
envinputare therefore removed from the custom before-install action;
IGRAPH_LIFECYCLE_ERRORS=truefrom the lifecycle-errors matrix entrykeeps reaching the tests through the workflow-level step.
Additionally, this PR regenerates the
ARG_HANDLEblocks(
Rscript tools/generate-migrations.R, generated code only):current
maincarries drift —most likely from the merge order of today's migration refactors
(#2760, #2761, #2762 and the registry side of #2782) —
and the rcc-smoke drift check fails on every branch
until the regenerated blocks are committed.
The first CI run on this PR failed exactly there,
before the regeneration commit was added.
🤖 Generated with Claude Code
https://claude.ai/code/session_0136C9bRMjBGkUrtLdkYNmAg