Skip to content

Don't exit on failure if cert-checker finds bad certs#8866

Open
lenaunderwood22 wants to merge 1 commit into
mainfrom
cert-checker-no-failure-exit
Open

Don't exit on failure if cert-checker finds bad certs#8866
lenaunderwood22 wants to merge 1 commit into
mainfrom
cert-checker-no-failure-exit

Conversation

@lenaunderwood22

Copy link
Copy Markdown
Contributor

No description provided.

@lenaunderwood22 lenaunderwood22 requested a review from a team as a code owner July 10, 2026 18:24
@lenaunderwood22 lenaunderwood22 requested a review from jsha July 10, 2026 18:24

@jsha jsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You've described separately why this is the desired behavior. Would you mind updating the PR description with that description? Thanks!

@ezekiel

ezekiel commented Jul 10, 2026

Copy link
Copy Markdown
Member

Because we also run cert-checker as part of Boulder CI, I think we don't want to lose this behavior. We might want to make this an optional behavior based on a flag? Or, we could follow-up in CI and specifically check the report or metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants