fix: return 404 when updating a missing member profile#4351
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
There was a problem hiding this comment.
Pull request overview
Correctly returns 404 for updates to missing members by checking the lookup result before audit-state capture.
Changes:
- Moves the null check before
record.get(). - Preserves audit capture for existing members.
Review note: The PR title is missing the required trailing JIRA key (CM-XXX).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 500 errors on
PUT /member/:idwhen the member no longer exists in the database.MemberRepository.updatecalledrecord.get()before verifyingfindOnereturned a row, causingTypeError: Cannot read properties of null (reading 'get')instead of a proper 404.Changes
captureOldStateinMemberRepository.update, matching the pattern already used inorganizationRepository.update.