Switch to per-user install and fix script execution issues#2548
Open
hillary-mutisya wants to merge 4 commits into
Open
Switch to per-user install and fix script execution issues#2548hillary-mutisya wants to merge 4 commits into
hillary-mutisya wants to merge 4 commits into
Conversation
Three critical fixes: 1. Variable reference syntax in error message (use brace expansion) 2. Copilot CLI detection fallback for -NoProfile mode 3. Plugin directory naming: rename copied dir to match marketplace entry 4. Line continuation: backtick instead of backslash Result: Script runs successfully, registers local marketplace, installs plugin
hillary-mutisya
requested a deployment
to
development-fork
GitHub Actions
Waiting
hillary-mutisya
requested a deployment
to
development-fork
GitHub Actions
Waiting
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the TypeAgent MSI installer and Copilot plugin registration process, with a focus on switching to per-user installation, hardening plugin registration, and improving logging and error handling. It also restricts MSI builds to
win32-x64and refines the plugin marketplace generation logic.Installer packaging and installation scope:
%LOCALAPPDATA%\TypeAgentrather thanC:\Program Files\TypeAgent, switching from a per-machine to a per-user installation (InstallScope="perUser", directory changes, registry moved toHKCU). [1] [2] [3] [4] [5] [6]win32-x64; other RIDs such aswin32-arm64are no longer supported, and the build script enforces this. [1] [2]Copilot plugin registration and logging:
register-plugin.ps1script is completely rewritten to:Marketplace and plugin manifest generation:
build-msi.mjs) now uses the plugin version (not the agent version) for the marketplace manifest, ensuring the correct version is reflected. [1] [2]These changes collectively improve the reliability, user experience, and maintainability of the TypeAgent MSI installer and Copilot CLI plugin integration.