Use NUnit key constraints in DSCv3 settings tests#6371
Merged
florelis merged 1 commit intoJul 15, 2026
Conversation
* Replace ContainsKey boolean assertions with NUnit built-in key constraints in admin settings and user settings DSCv3 E2E tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Trenly
marked this pull request as ready for review
July 15, 2026 21:51
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
florelis
approved these changes
Jul 15, 2026
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DSCv3 Settings E2E tests to use NUnit’s dictionary key constraints (e.g., Contains.Key(...) / Does.Not.ContainKey(...)) rather than asserting on boolean ContainsKey(...) results, improving assertion clarity and failure messages in the test suite.
Changes:
- Replaced
ContainsKey(...) == true/falseassertions withContains.Key(...)andDoes.Not.ContainKey(...)constraints in admin settings DSCv3 tests. - Updated mock-property assertions in user settings file DSCv3 tests to use key constraints for both top-level and nested JSON objects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/AppInstallerCLIE2ETests/DSCv3AdminSettingsResourceCommand.cs | Swaps boolean ContainsKey asserts for NUnit key constraints across admin-settings resource get/test/set flows. |
| src/AppInstallerCLIE2ETests/DSCv3UserSettingsFileResourceCommand.cs | Uses NUnit key constraints to validate presence of mock settings keys (including nested keys) in JSON settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR updates Settings E2E tests to use NUnit built-in key constraints instead of boolean
ContainsKey(...)checks.Changed files:
src/AppInstallerCLIE2ETests/DSCv3AdminSettingsResourceCommand.cssrc/AppInstallerCLIE2ETests/DSCv3UserSettingsFileResourceCommand.csThis was prepared with assistance from GitHub Copilot.
🔗 References
Resolves #6369
🔍 Validation
Not run in this session (user runs builds/tests).
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow