JSON > + [keep/exclude]_routes.route_short_name_regex #NRT#79
Merged
Conversation
mmathieum
marked this pull request as ready for review
July 14, 2026 13:46
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces regex-based route filtering by adding a route_short_name_regex configuration option to RouteConfig. This regex is lazily compiled and used in both keepRoutes and excludeRoutes to match route short names. The review feedback suggests ensuring the regex string is not blank before compiling to avoid unexpected matching behavior, and recommends adding unit tests to verify the new filtering logic.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
mmathieum
added a commit
to mtransitapps/ca-welland-transit-bus-android
that referenced
this pull request
Jul 14, 2026
…ort_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/mtransit-for-android
that referenced
this pull request
Jul 14, 2026
…e_short_name_regex` #NRT mtransitapps/parser#79
mmathieum
added a commit
to mtransitapps/ca-welland-transit-bus-android
that referenced
this pull request
Jul 14, 2026
* `JSON` config... * Sync code from 'parser': `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/ca-gta-up-express-train-android
that referenced
this pull request
Jul 14, 2026
- commons-android: GTFS-RT > Trip filtering > allow ignore `direction_id` when `trip_id` is provided mtransitapps/commons-android#172 - commons-android: Status > `hasData` != `!noData` ('no data' means loaded w/o data) mtransitapps/commons-android#173 - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/ca-st-hyacinthe-transport-collectif-bus-android
that referenced
this pull request
Jul 15, 2026
- commons-java: String utils > "and" -> "&" always (tests) - commons-java: String utils > "and" -> "&" always - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/ca-moose-jaw-transit-bus-android
that referenced
this pull request
Jul 15, 2026
- commons-java: String utils > "and" -> "&" always (tests) - commons-java: String utils > "and" -> "&" always - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/ca-mrc-nicolet-yamaska-bili-bus-android
that referenced
this pull request
Jul 15, 2026
- commons-android: GTFS-RT > Trip filtering > allow ignore `direction_id` when `trip_id` is provided mtransitapps/commons-android#172 - commons-java: String utils > "and" -> "&" always (tests) - commons-java: String utils > "and" -> "&" always - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
mmathieum
added a commit
to mtransitapps/ca-edmonton-ets-bus-android
that referenced
this pull request
Jul 15, 2026
…er': - commons: Gradle 9.4+ > enable parallel sync - commons-android: GTFS-RT > Trip filtering > allow ignore `direction_id` when `trip_id` is provided mtransitapps/commons-android#172 - commons-android: Status > `hasData` != `!noData` ('no data' means loaded w/o data) mtransitapps/commons-android#173 - commons-java: String utils > "and" -> "&" always (tests) - commons-java: String utils > "and" -> "&" always - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/ca-ottawa-oc-transpo-bus-android
that referenced
this pull request
Jul 17, 2026
…parser': - commons: Build(deps): Bump com.google.ads.mediation:facebook from 6.21.0.3 to 6.21.0.4 in the ads group across 1 directory mtransitapps/commons#813 - commons: Build(deps): Bump com.google.firebase:firebase-bom from 34.15.0 to 34.16.0 in the gms group across 1 directory mtransitapps/commons#812 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.9 to 2.3.10 in the kotlin-ksp-compose group across 1 directory mtransitapps/commons#811 - commons: Gradle 9.4+ > enable parallel sync - commons-android: GTFS-RT > Trip filtering > allow ignore `direction_id` when `trip_id` is provided mtransitapps/commons-android#172 - commons-android: Status > `hasData` != `!noData` ('no data' means loaded w/o data) mtransitapps/commons-android#173 - commons-java: String utils > "and" -> "&" always (tests) - commons-java: String utils > "and" -> "&" always - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
montransit
added a commit
to mtransitapps/ca-ottawa-oc-transpo-train-android
that referenced
this pull request
Jul 17, 2026
…parser': - commons: Build(deps): Bump com.google.ads.mediation:facebook from 6.21.0.3 to 6.21.0.4 in the ads group across 1 directory mtransitapps/commons#813 - commons: Build(deps): Bump com.google.firebase:firebase-bom from 34.15.0 to 34.16.0 in the gms group across 1 directory mtransitapps/commons#812 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.9 to 2.3.10 in the kotlin-ksp-compose group across 1 directory mtransitapps/commons#811 - commons: Gradle 9.4+ > enable parallel sync - commons-android: GTFS-RT > Trip filtering > allow ignore `direction_id` when `trip_id` is provided mtransitapps/commons-android#172 - commons-android: Status > `hasData` != `!noData` ('no data' means loaded w/o data) mtransitapps/commons-android#173 - commons-java: String utils > "and" -> "&" always (tests) - commons-java: String utils > "and" -> "&" always - parser: `JSON` > + `[keep/exclude]_routes`.`route_short_name_regex` #NRT mtransitapps/parser#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.