Add support for pre-ACCELERATE_NEW_LAPACK Accelerate on iOS.#25
Add support for pre-ACCELERATE_NEW_LAPACK Accelerate on iOS.#25freakboy3742 wants to merge 1 commit into
Conversation
|
One side thought - it would be possible to extend this to allow for pre-NEW_LAPACK Accelerate support on macOS as well, using a similar pattern; however, I don't know if there's any interest in that. |
|
Not really. Both because that old Accelerate is pretty buggy (see https://github.com/scipy/archive/blob/main/wiki/dropping-accelerate-support.md), and because I don't really want to spend time or increase complexity to deal with building from source on macOS versions that old. |
|
I figured that was likely the case. I just wanted to mention the option since the parallel exists. |
|
@rgommers Just following up on this; is this a change you're comfortable with? |
|
@rgommers Sorry to nag on this one - but any update on whether this can be merged? It's currently the last remaining blocker on iOS support for NumPy. |
Accelerate has three flavours:
ACCELERATE_NEW_LAPACK is only available from macOS 13.3/iOS 16.4.
This PR enables the use of Accelerate on older iOS releases (back to 13.0), but disables the use of ACCELERATE_NEW_LAPACK on those versions.