Skip to content

Build universal macOS release artifact#58

Merged
steipete merged 2 commits into
openclaw:mainfrom
TurboTheTurtle:tt/remindctl-57-universal-macos-release
Jun 30, 2026
Merged

Build universal macOS release artifact#58
steipete merged 2 commits into
openclaw:mainfrom
TurboTheTurtle:tt/remindctl-57-universal-macos-release

Conversation

@TurboTheTurtle

@TurboTheTurtle TurboTheTurtle commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Closes #57.

Builds the macOS release artifact through a shared universal binary packaging script so the Homebrew-consumed zip contains both arm64 and x86_64 slices. The release workflow now validates the packaged archive with lipo/file checks, and the notarization helper reuses the same universal build path.

Real behavior proof:

  • Real environment tested: macOS 27.0 (26A5353q), arm64 host, Xcode 26.5, Swift 6.3.2.
  • Exact steps or command run after this patch: make macos-artifact; unzip dist/remindctl-macos.zip; run file, lipo -info, and scripts/check-macos-artifact.sh dist/remindctl-macos.zip on the generated archive.
  • Evidence after fix: the archive extracted to one top-level remindctl binary; file reported Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]; lipo -info reported Architectures in the fat file ... are: x86_64 arm64.
  • Observed result after fix: scripts/check-macos-artifact.sh dist/remindctl-macos.zip passed.
  • What was not tested: execution on physical Intel Mac hardware and notarized release upload.

@TurboTheTurtle

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. labels Jun 19, 2026
@clawsweeper

clawsweeper Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed June 30, 2026, 12:07 AM ET / 04:07 UTC.

Summary
The branch replaces the macOS tag-release packaging step with shared universal build, package, and verification scripts, adds make macos-artifact, updates release docs, and reuses the universal build helper from notarization.

Reproducibility: yes. for the source-level release path: current main builds and zips one default-architecture macOS binary, matching the linked Intel Mac artifact failure. I did not rerun the shipped artifact on physical Intel macOS in this review.

Review metrics: 2 noteworthy metrics.

  • Release automation surface: 1 workflow modified; 3 executable scripts added; 1 signing helper changed. The changed files sit on the tag release path that publishes the Homebrew-consumed macOS artifact.
  • Patch size: 7 files changed, +125/-35. The diff is bounded, but broad enough to warrant focused maintainer release-path review.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #57
Summary: This PR is the open implementation candidate for the canonical Intel Mac arm64-only release artifact bug.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • A maintainer release dry run would further reduce confidence risk for the tag workflow and notarization path.

Risk before merge

  • [P1] The PR changes the tag release packaging path that publishes the Homebrew-consumed archive; ordinary PR checks do not exercise the full tag release, upload, and tap-dispatch path end to end.
  • [P1] The provided proof validates local macOS artifact creation and architecture checks, but not physical Intel Mac execution or a notarized release upload.

Maintainer options:

  1. Accept artifact proof and merge after normal gates (recommended)
    Maintainers can accept the PR body's macOS artifact output as sufficient for merge, with the first full tag-release run still validating upload and tap-dispatch behavior.
  2. Run a controlled release dry run first
    A maintainer can run the packaging path or a controlled tag-release dry run before merge to reduce the remaining automation uncertainty.

Next step before merge

  • [P2] No repair PR is queued because there is no concrete patch defect; maintainers need to decide whether the provided artifact proof is enough for the release automation risk.

Security
Cleared: The diff changes release automation but adds no third-party actions, dependencies, broader workflow permissions, or new secret exposure.

Review details

Best possible solution:

Land this shared universal packaging path, or an equivalent maintainer-approved release-path fix, after maintainer review accepts the artifact proof and release automation risk.

Do we have a high-confidence way to reproduce the issue?

Yes for the source-level release path: current main builds and zips one default-architecture macOS binary, matching the linked Intel Mac artifact failure. I did not rerun the shipped artifact on physical Intel macOS in this review.

Is this the best way to solve the issue?

Yes: the shared universal build, package, and check path is the narrow maintainable fix for the release artifact bug. The remaining question is release automation acceptance, not a different implementation direction.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning high; reviewed against 4e8643ff0ed9.

Label changes

Label justifications:

  • P2: The PR addresses a bounded release-packaging bug that blocks Intel Mac users from running the distributed CLI.
  • merge-risk: 🚨 automation: Merging changes the GitHub release packaging workflow and local release scripts that ordinary PR CI does not run end to end.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body provides after-fix macOS live output for building, unzipping, inspecting, and checking the generated universal zip.
  • proof: sufficient: Contributor real behavior proof is sufficient. The PR body provides after-fix macOS live output for building, unzipping, inspecting, and checking the generated universal zip.
Evidence reviewed

What I checked:

  • Target AGENTS.md absent: No AGENTS.md exists under the target repository checkout, so no target-specific AGENTS policy applied.
  • Current main still packages one default-architecture binary: The current main release workflow runs one swift build -c release --product remindctl, signs .build/release/remindctl, and zips that single binary as dist/remindctl-macos.zip. (.github/workflows/release.yml:53, 4e8643ff0ed9)
  • Current release docs make the workflow the shipped artifact path: The release guide says pushed v* tags run the release workflow, build remindctl-macos.zip, publish the release, and dispatch the Homebrew tap update. (docs/RELEASING.md:18, 4e8643ff0ed9)
  • Existing universal logic was local-only on main: Current main already has dual-arch swift build --arch plus lipo logic in the notarization helper, but the publishing workflow does not call that helper. (scripts/sign-and-notarize.sh:32, 4e8643ff0ed9)
  • PR adds executable shared packaging scripts: The PR commit adds executable universal build, artifact check, and package scripts; the package script calls the universal build helper before codesigning and checking the zip. (scripts/package-macos-release.sh:20, 458c13cd3329)
  • PR wires the release workflow to the package script: The tag release job changes from inline single-arch build/sign/zip commands to scripts/package-macos-release.sh. (.github/workflows/release.yml:49, 458c13cd3329)

Likely related people:

  • Peter Steinberger: Blame and release-file history attribute the current release workflow packaging path, release docs, Makefile release target, and notarization helper to release-prep and adjacent release automation commits. (role: release workflow author and recent area contributor; confidence: high; commits: 04fbfd02e76f, f94c15df25e5, 11f1a6f2af75; files: .github/workflows/release.yml, scripts/sign-and-notarize.sh, docs/RELEASING.md)
  • Vincent Koc: History shows a recent macOS runner-label change in the same release workflow surface touched by this PR. (role: adjacent workflow contributor; confidence: medium; commits: 569b249b1984; files: .github/workflows/release.yml)
  • Dinakar Sarbada: History shows Homebrew tap release-flow work in the same distribution path that consumes the generated macOS artifact. (role: adjacent release-flow contributor; confidence: medium; commits: 74beefa96ae2; files: docs/RELEASING.md, scripts/update-homebrew.sh)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@TurboTheTurtle

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jun 19, 2026
@steipete steipete merged commit e5b5f75 into openclaw:main Jun 30, 2026
1 check passed
@TurboTheTurtle TurboTheTurtle deleted the tt/remindctl-57-universal-macos-release branch July 1, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remindctl ships arm64-only — "Bad CPU type in executable" on Intel Macs

2 participants