8154193: Move jdk.naming.rmi module to platform class loader

[jaikiran]

Can I please get a review of this change which moves the jdk.naming.rmi module to be loaded by the platform loader, instead of the boot loader?

This module doesn't require anything that would necessitate it to be part of the boot loader modules and such can be moved to the modules that belong to the platform loader.

This module provides the javax.naming.spi.InitialContextFactory service. Before this change, the service would be located and loaded using the boot classloader and now will instead be loaded using the platform classloader. I believe this change to the service loading is an observable change and would thus require a CSR. I'll create one shortly.

A new jtreg test has been introduced to verify that the InitialContextFactory service provided by the jdk.naming.rmi module doesn't get loaded by the boot loader. The test passes with this change and fails (as expected) without the source change.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires a CSR request matching fixVersion 28 to be approved (needs to be created)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8154193: Move jdk.naming.rmi module to platform class loader (Enhancement - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31480/head:pull/31480
$ git checkout pull/31480

Update a local copy of the PR:
$ git checkout pull/31480
$ git pull https://git.openjdk.org/jdk.git pull/31480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31480

View PR using the GUI difftool:
$ git pr show -t 31480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31480.diff

Using Webrev

Link to Webrev Comment

[jaikiran]

/csr needed

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@jaikiran has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@jaikiran please create a CSR request for issue JDK-8154193 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@jaikiran The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (169132e1)

[seanjmullan]

The title of the issue could be changed, as deprivileging means granting fewer permissions which no longer applies since the Security Manager is permanently disabled. Maybe change to "Move jdk.naming.rmi module to platform class loader"

[jaikiran]

Maybe change to "Move jdk.naming.rmi module to platform class loader"

Done.