Skip to content

8385927: JDK 27 RDP1 L10n resource files update#31486

Open
justin-curtis-lu wants to merge 5 commits into
openjdk:masterfrom
justin-curtis-lu:JDK-8385927-RDP1-L10N
Open

8385927: JDK 27 RDP1 L10n resource files update#31486
justin-curtis-lu wants to merge 5 commits into
openjdk:masterfrom
justin-curtis-lu:JDK-8385927-RDP1-L10N

Conversation

@justin-curtis-lu

@justin-curtis-lu justin-curtis-lu commented Jun 11, 2026

Copy link
Copy Markdown
Member

Localization updates for JDK 27 RDP1.

For easier review, you can also view the changes side-by-side with the corresponding English changes here:
https://cr.openjdk.org/~jlu/output/. Note that translations come from upstream as usual, so any modifications made in this PR will also need to be applied upstream. While most changes are the result of updates to the corresponding English values, it is not unusual to also see some updates to existing translations.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8385927: JDK 27 RDP1 L10n resource files update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31486/head:pull/31486
$ git checkout pull/31486

Update a local copy of the PR:
$ git checkout pull/31486
$ git pull https://git.openjdk.org/jdk.git pull/31486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31486

View PR using the GUI difftool:
$ git pr show -t 31486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31486.diff

Using Webrev

Link to Webrev Comment

validity.number.of.days=有效天数
Serial.ID.of.cert.to.revoke=要撤销的证书的序列 ID
# keytool: Running part
keytool.error.=keytool 错误:\u0020

@justin-curtis-lu justin-curtis-lu Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change and similar ones are expected. Trailing white space is no longer required when the last char is a full-width colon which zh_CN files commonly do.

@bridgekeeper

bridgekeeper Bot commented Jun 11, 2026

Copy link
Copy Markdown

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 11, 2026

Copy link
Copy Markdown

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385927: JDK 27 RDP1 L10n resource files update

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added javadoc javadoc-dev@openjdk.org security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Jun 11, 2026
@openjdk

openjdk Bot commented Jun 11, 2026

Copy link
Copy Markdown

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • javadoc
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@justin-curtis-lu justin-curtis-lu marked this pull request as ready for review June 11, 2026 18:21
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 11, 2026
@mlbridge

mlbridge Bot commented Jun 11, 2026

Copy link
Copy Markdown

Webrevs


compiler.misc.incompatible.arg.types.in.lambda=ラムダ式のパラメータ型は不適合です
# 0: list of type or message segment, 1: list of type or message segment
compiler.misc.incompatible.arg.types.in.lambda=ラムダ式のパラメータ型は不適合です\n期待値: {0}\n検出値: {1}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those extra spaces between "検出値:\u0020" and "{1}" seems unnecessary. Original English resource has these spaces to align the placeholders, but not needed for Japanese

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Curious as to why the de translation for this key came back without the extra spaces, but the ja one did. Assuming zh_CN operated differently given its full width colon.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess de/zh_CN translators were aware of the original alignment. De translator simply removed them, zh_CN translator removed them which happened to align placeholders. Ja translator simply copied them over.

# {0} = path of jimage file, {1} = underlying error message
err.invalid.jimage={0}を開けません: {1}
# More specific alternative for cases of version mismatch
err.wrong.version={0}を開けません: ファイルとツールのバージョンが一致していません\njimageファイルに関連付けられたJDKには''<JAVA_HOME>/bin/jimage''を使用してください:\n{1}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this translation is not accurate. The second sentence should be something along the lines of:

jimageファイルに関連付けられたJDKの''<JAVA_HOME>/bin/jimage''を使用してください:\n{1}

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org javadoc javadoc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants