8385743: [lworld] investigate and address build related comments in the Valhalla PR by dcubed-ojdk · Pull Request #2541 · openjdk/valhalla

dcubed-ojdk · 2026-06-12T16:33:36Z

I've taken a pass at resolving most of @erikj79's build related comments in the Valhalla PR:

JDK-8317279 Standard library implementation of value classes and objects
openjdk/jdk#31123

A couple of the comments will be handled by separate issues:

JDK-8386451 [lworld] things to delete from lworld just before integrating JEP-401
JDK-8386458 [lworld] add support for allowing value classes to declare native methods

In this PR, I have reverted two of @MrSimms' heap sizes of 3200 to the main-line's 2048.
I am testing this change with a Mach5 Tier[1-8]. Mach5 Tier[123458] have completed
and there are no related test or task failures. Mach5 Tier[67] are still executing and
are currently waiting for Mach5 resources.

Update: I have added links to the comments in JDK-8317279 that discuss my analysis
of the original code, where it came from and my proposed fix; gory details as it were.

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

JDK-8385743: [lworld] investigate and address build related comments in the Valhalla PR (Bug - P4)

Reviewers

Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2541/head:pull/2541
$ git checkout pull/2541

Update a local copy of the PR:
$ git checkout pull/2541
$ git pull https://git.openjdk.org/valhalla.git pull/2541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2541

View PR using the GUI difftool:
$ git pr show -t 2541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2541.diff

Using Webrev

Link to Webrev Comment

…he Valhalla PR

dcubed-ojdk · 2026-06-12T16:34:24Z

Ping @erikj79 and @MrSimms - Please review when you get the chance. Thanks!

bridgekeeper · 2026-06-12T16:35:58Z

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

dcubed-ojdk · 2026-06-12T16:36:44Z

  JVM_HEAP_LIMIT_32="768"
  # Running a 64 bit JVM allows for and requires a bigger heap
-  JVM_HEAP_LIMIT_64="3200"
+  JVM_HEAP_LIMIT_64="2048"


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884164&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884164 for gory details.

dcubed-ojdk · 2026-06-12T16:37:05Z

 # Use hard-coded values for java flags (one size, fits all!)
 JAVA_FLAGS := -Duser.language=en -Duser.country=US
-JAVA_FLAGS_BIG := -Xms64M -Xmx3200M
+JAVA_FLAGS_BIG := -Xms64M -Xmx2048M


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884164&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884164 for gory details.

openjdk · 2026-06-12T16:37:23Z

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385743: [lworld] investigate and address build related comments in the Valhalla PR

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

dcubed-ojdk · 2026-06-12T16:38:10Z

-  JVM_EXCLUDE_FILES += templateInterpreter.cpp templateInterpreterGenerator.cpp \
-                       bcEscapeAnalyzer.cpp ciTypeFlow.cpp macroAssembler_common.cpp
-  JVM_CFLAGS_FEATURES += -DZERO -DZERO_LIBARCH='"$(OPENJDK_TARGET_CPU_LEGACY_LIB)"' $(LIBFFI_CFLAGS)
+  JVM_EXCLUDE_FILES += templateInterpreter.cpp \
+      templateInterpreterGenerator.cpp bcEscapeAnalyzer.cpp ciTypeFlow.cpp \
+      macroAssembler_common.cpp
+  JVM_CFLAGS_FEATURES += -DZERO \
+      -DZERO_LIBARCH='"$(OPENJDK_TARGET_CPU_LEGACY_LIB)"' $(LIBFFI_CFLAGS)


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884182&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884182 for the gory details.

dcubed-ojdk · 2026-06-12T16:38:51Z

 # Generate the value class replacements for selected java.base source files

-java.base-VALUE_CLASS-REPLACEMENTS := \
+JAVA_BASE_VALUE_CLASS_REPLACEMENTS := \


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884197&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884197 for the gory details.

dcubed-ojdk · 2026-06-12T16:39:47Z

-  VARHANDLE_$1_type := $$(strip $$(if $$(filter $(VARHANDLE_OBJECT_TYPES), $1), Object, $1))
-  VARHANDLE_$1_InputType := $$(strip $$(if $$(filter $(VARHANDLE_OBJECT_TYPES), $1), $1, $$(call Conv, $1, Type)))
-  VARHANDLE_$1_Type := $$(strip $$(subst NonAtomicReference, Reference, $$(subst NonAtomicFlatValue, FlatValue, $$(VARHANDLE_$1_InputType))))
+  VARHANDLE_$1_type := \
+      $$(strip $$(if $$(filter $(VARHANDLE_OBJECT_TYPES), $1), Object, $1))
+  VARHANDLE_$1_InputType := \
+      $$(strip $$(if $$(filter $(VARHANDLE_OBJECT_TYPES), $1), $1, \
+      $$(call Conv, $1, Type)))
+  VARHANDLE_$1_Type := \
+      $$(strip $$(subst NonAtomicReference, Reference, \
+      $$(subst NonAtomicFlatValue, FlatValue, $$(VARHANDLE_$1_InputType))))


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884223&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884223 for the gory details.

dcubed-ojdk · 2026-06-12T16:40:27Z

-#  valueClassPlugin.jar      -- contains ValueClassPlugin (a javac Plugin that
-#                               rewrites @AsValueClass classes to value classes
-#                               at parse time) together with @AsValueClass and
-#                               the META-INF service descriptor, compiled WITH
-#                               --enable-preview and the required internal-API
-#                               exports.
+#  valueClassPlugin.jar -- Contains ValueClassPlugin (a javac Plugin that
+#    rewrites @AsValueClass classes to value classes at parse time) together
+#    with @AsValueClass and the META-INF service descriptor, compiled WITH
+#    --enable-preview and the required internal-API exports.


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884232&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884232 for the gory details.

dcubed-ojdk · 2026-06-12T16:41:08Z

-include MakeFileEnd.gmk
+include MakeFileEnd.gmk


This puzzled me for a minute, then I remembered that the original file was missing an at the end.

dcubed-ojdk · 2026-06-12T16:41:36Z

    HEADERS := $(TEST_LIB_SUPPORT)/test-lib_headers, \
    JAR := $(TEST_LIB_SUPPORT)/test-lib.jar, \
-    DISABLED_WARNINGS := try deprecation rawtypes unchecked serial cast removal preview restricted varargs dangling-doc-comments, \
+    DISABLED_WARNINGS := preview, \


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884501&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884501 for the gory details.

dcubed-ojdk · 2026-06-12T16:42:46Z

-  # Temporarily compile preview classes into a separate directory, and then
-  # copy into the correct output path location.
-  # We cannot compile directly into the desired directory because it's the
-  # compiler which creates the original '<module>/<classpath>/...' hierarchy.
+  # Compile preview classes into a separate directory, and then copy into the
+  # correct output path location. We cannot compile directly into the desired
+  # directory because it's the compiler which creates the original
+  # '<module>/<classpath>/...' hierarchy.


See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884574&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884574 for the gory details.

Several of @erikj79's comments were resolved by another fix.

mlbridge · 2026-06-12T16:48:16Z

Webrevs

00: Full (0c6bf15e)

liach

lgtm

dcubed-ojdk · 2026-06-12T18:27:21Z

@liach - Thanks for the review!

dcubed-ojdk added 2 commits June 12, 2026 10:23

8385743: [lworld] investigate and address build related comments in t…

4a14539

…he Valhalla PR

Try using the current baseline values of 2048 instead of 3200.

0c6bf15

dcubed-ojdk commented Jun 12, 2026

View reviewed changes

openjdk Bot added the rfr Pull request is ready for review label Jun 12, 2026

dcubed-ojdk commented Jun 12, 2026

View reviewed changes

liach approved these changes Jun 12, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Jun 12, 2026

		include MakeFileEnd.gmk No newline at end of file
		include MakeFileEnd.gmk

Conversation

dcubed-ojdk commented Jun 12, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

dcubed-ojdk commented Jun 12, 2026

Uh oh!

bridgekeeper Bot commented Jun 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlbridge Bot commented Jun 12, 2026

Webrevs

Uh oh!

liach left a comment

Choose a reason for hiding this comment

Uh oh!

dcubed-ojdk commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

dcubed-ojdk commented Jun 12, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Jun 12, 2026 •

edited

Loading