OCPBUGS-89337: fix for release-4.22 by matzew · Pull Request #16638 · openshift/console

matzew · 2026-06-17T14:21:12Z

A manual cherry pick for #16606

…r accumulation The downloads server previously created a new random temp directory via os.MkdirTemp on each startup. When Kubernetes restarts the container (without deleting the pod), the emptyDir volume persists and each restart leaves behind ~3.1G of orphaned artifacts. The defer-based cleanup in main() only runs on graceful exit, not on SIGKILL. Switch to a fixed, well-known path (/tmp/artifacts) and clean it on startup with os.RemoveAll before re-creating it. This guarantees at most one copy of the artifacts exists at any time. Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Address review feedback: - Use filepath.Glob("/tmp/artifacts*") to also remove stale random temp directories left by the old os.MkdirTemp code (e.g. /tmp/artifacts1234567890). The first deployment with the fixed path would otherwise leave those orphaned dirs behind. - Add unit tests for NewDownloadsServerConfig directory handling: 1. Clean start creates the directory and populates it 2. Restart with stale data cleans up and recreates correctly 3. Old random temp dirs (/tmp/artifacts*) are also cleaned up Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

openshift-ci-robot · 2026-06-17T14:21:19Z

@matzew: This pull request references Jira Issue OCPBUGS-88450, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-88450 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

A manual cherry pick for #16606

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-06-17T14:23:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matzew
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

cmd/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

praveenkumar · 2026-06-17T14:33:31Z

/jira refresh

openshift-ci-robot · 2026-06-17T14:33:36Z

@praveenkumar: This pull request references Jira Issue OCPBUGS-88450, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-88450 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

praveenkumar · 2026-06-17T14:34:40Z

/title OCPBUGS-89337: fix for release-4.22

matzew · 2026-06-17T14:53:22Z

/retitle OCPBUGS-89337: fix for release-4.22

openshift-ci-robot · 2026-06-17T14:53:32Z

@matzew: This pull request references Jira Issue OCPBUGS-89337, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-89337 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

A manual cherry pick for #16606

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

matzew · 2026-06-17T14:54:45Z

/jira refresh

openshift-ci-robot · 2026-06-17T14:54:49Z

@matzew: This pull request references Jira Issue OCPBUGS-89337, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

matzew · 2026-06-17T14:55:32Z

/jira refresh

openshift-ci-robot · 2026-06-17T14:55:40Z

@matzew: This pull request references Jira Issue OCPBUGS-89337, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-88450 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-88450 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-06-17T17:35:16Z

@matzew: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-merge-robot · 2026-06-18T06:05:29Z

Fix included in release 5.0.0-0.nightly-2026-06-18-000016

praveenkumar · 2026-06-18T15:02:19Z

@jhadvig can you please take a look into this?

matzew and others added 2 commits June 17, 2026 16:17

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2026

openshift-ci Bot requested review from Leo6Leo and jhadvig June 17, 2026 14:23

openshift-ci Bot added the component/backend Related to backend label Jun 17, 2026

openshift-ci Bot changed the title ~~OCPBUGS-88450: fix for release-4.22~~ OCPBUGS-89337: fix for release-4.22 Jun 17, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2026

Conversation

matzew commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

praveenkumar commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

praveenkumar commented Jun 17, 2026

Uh oh!

matzew commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

matzew commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

matzew commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

openshift-merge-robot commented Jun 18, 2026

Uh oh!

praveenkumar commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants