Skip to content

CLID-589: add oc-mirror to extensionBinaries#31308

Open
adolfo-ab wants to merge 1 commit into
openshift:mainfrom
adolfo-ab:oc-mirror-ote
Open

CLID-589: add oc-mirror to extensionBinaries#31308
adolfo-ab wants to merge 1 commit into
openshift:mainfrom
adolfo-ab:oc-mirror-ote

Conversation

@adolfo-ab

@adolfo-ab adolfo-ab commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Added an external test binary to the testing infrastructure for improved test coverage.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 16, 2026

Copy link
Copy Markdown

@adolfo-ab: This pull request references CLID-589 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 64e81944-2798-435c-beff-736e929f102a

📥 Commits

Reviewing files that changed from the base of the PR and between c7deaba and 00f16d8.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

A new TestBinary entry is appended to the extensionBinaries slice in pkg/test/extensions/binary.go, registering the oc-mirror payload image with the extracted binary path /usr/bin/oc-mirror-tests-ext.gz. No other logic is changed.

Changes

oc-mirror external test binary registration

Layer / File(s) Summary
Register oc-mirror TestBinary entry
pkg/test/extensions/binary.go
Adds a TestBinary entry to extensionBinaries for the oc-mirror image tag, referencing the binary at /usr/bin/oc-mirror-tests-ext.gz.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding oc-mirror to extensionBinaries, which matches the file modification shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The file contains no Ginkgo test name definitions (It, Describe, Context, etc.). The change only adds a static configuration entry for oc-mirror binary path, which has no dynamic values and is not...
Test Structure And Quality ✅ Passed PR modifies pkg/test/extensions/binary.go to add oc-mirror to extensionBinaries config list. File contains no Ginkgo tests (It/Describe/BeforeEach blocks), so the Ginkgo test quality check is not a...
Microshift Test Compatibility ✅ Passed PR adds only a data structure entry for an external test binary (oc-mirror), not new Ginkgo e2e tests. The check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests. It only adds configuration metadata (one entry to extensionBinaries array) registering an external oc-mirror test binary.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only a test framework file (pkg/test/extensions/binary.go) to register a test binary from the oc-mirror payload image. No deployment manifests, operator code, controllers, or sched...
Ote Binary Stdout Contract ✅ Passed PR only adds static reference to oc-mirror binary in extensionBinaries list; no stdout writes or process-level code changes introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds metadata registry entry for oc-mirror test binary, not new Ginkgo e2e tests. Check is not applicable.
No-Weak-Crypto ✅ Passed The PR only adds a test binary reference to extensionBinaries. No cryptographic imports, weak crypto usage (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant...
Container-Privileges ✅ Passed PR only adds a test binary reference (oc-mirror) to a Go data structure. No Kubernetes manifests, container configs, or privileged settings are introduced.
No-Sensitive-Data-In-Logs ✅ Passed PR adds a single oc-mirror entry to extensionBinaries array with no logging statements and no sensitive data (passwords, tokens, APIs keys, PII, session IDs, hostnames, or customer data).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deads2k and p0lyn0mial June 16, 2026 08:19
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adolfo-ab
Once this PR has been reviewed and has the lgtm label, please assign miyadav for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 16, 2026
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@adolfo-ab: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants