fix(OutlinedCopy): Replace OutlinedCopy with RhUiCopyIcon#12453
fix(OutlinedCopy): Replace OutlinedCopy with RhUiCopyIcon#12453rebeccaalpert wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThis PR replaces the PatternFly ChangesCompass icon replacement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12453.surge.sh A11y report: https://pf-react-pr-12453-a11y.surge.sh |
| import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; | ||
| import OutlinedPlusSquare from '@patternfly/react-icons/dist/esm/icons/outlined-plus-square-icon'; | ||
| import OutlinedCopy from '@patternfly/react-icons/dist/esm/icons/outlined-copy-icon'; | ||
| import RhUiCopyIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-copy-icon'; |
There was a problem hiding this comment.
Think this could just be removed since it's not being used on the examples tab
There was a problem hiding this comment.
Good callout; none were being used, so I pulled them all.
What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.
Additional issues:
Summary by CodeRabbit