fix(ui): internationalize hardcoded labels in sidebar toggle#17244
Open
Coder909-byte wants to merge 1 commit into
Open
fix(ui): internationalize hardcoded labels in sidebar toggle#17244Coder909-byte wants to merge 1 commit into
Coder909-byte wants to merge 1 commit into
Conversation
Coder909-byte
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which branch should this PR target?
main — Payload v4 development. New features, enhancements, and v4 bug fixes go here.
What?
Internationalized the hardcoded fallback UI strings in the SidebarToggle component by integrating the useTranslation hook.
Why?
The "Hide sidebar" and "Show sidebar" labels were previously hardcoded in English prose within the component layout. To support proper internationalization and localization across the entire Payload admin panel dashboard, these labels need to pull dynamically from the application's global translation keys.
How?
Imported the useTranslation hook from @payloadcms/ui.
Extracted the t function inside the SidebarToggle component structure.
Replaced the hardcoded "Hide sidebar" text string with t('general:hideSidebar').
Replaced the hardcoded "Show sidebar" text string with t('general:showSidebar').