fix(ui): stop select filter infinite loop when leaving in/not_in#17291
Open
thribhuvan003 wants to merge 1 commit into
Open
fix(ui): stop select filter infinite loop when leaving in/not_in#17291thribhuvan003 wants to merge 1 commit into
thribhuvan003 wants to merge 1 commit into
Conversation
thribhuvan003
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
switching off in/not_in could leave an array value; the select effect kept calling onChange and hit max update depth. coerce for display and only write the scalar once.
thribhuvan003
force-pushed
the
fix/wherebuilder-select-multi-single-loop
branch
from
b102ebb to
55beb3e
Compare
thribhuvan003
changed the title
thribhuvan003
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17248
noticed the select list filter could blow up with max update depth after switching from
in/not_inback to something like equals. value was still an array and the effect kept calling onChange.coerce for display, write the scalar once, and don't write again for the same value. unit tests for the unwrap + the loop guard.