[ENHANCEMENT] TraceTable: use timezone setting from TimeRangeSelector#713
Open
andreasgerstmayr wants to merge 1 commit into
Open
[ENHANCEMENT] TraceTable: use timezone setting from TimeRangeSelector#713andreasgerstmayr wants to merge 1 commit into
andreasgerstmayr wants to merge 1 commit into
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
tracetable-timezone
branch
from
602cb85 to
9569276
Compare
andreasgerstmayr
changed the title
celian-garcia
approved these changes
Jun 30, 2026
| <Tooltip title={UTC_DATE_FORMATTER(new Date(row.startTimeUnixMs))} placement="top" arrow> | ||
| <Typography display="inline" key={`st-${row.traceId}`}> | ||
| {DATE_FORMATTER(new Date(row.startTimeUnixMs))} | ||
| <Tooltip title={dateFormatterUTC(row.startTimeUnixMs)} placement="top" arrow> |
Member
There was a problem hiding this comment.
Not related to this PR, but generally the tooltip serve to give a precise date.
Like the display is "2 days ago" and the tooltip is "December 18, 2023 at 4:07:25.000 PM"
Here both display and tooltip shows a precise date, but there's no clue for the user to know it's actually the UTC time displayed in the tooltip. Is there ?
Can you give a little screenshot ?
Member
There was a problem hiding this comment.
Okay, well I would say why not in the end. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tracetable: use timezone setting from TimeRangeSelector instead of local time
Screenshots
No UI changes, except that the timezone from the TimeRangeSelector is respected.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes