Fixes 'spo user get' retrieving user by id#7459
Open
milanholemans wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #7458 by fixing m365 spo user get so it can retrieve a SharePoint user by ID (as passed from the CLI), updating option typing/validation and extending validation tests.
Changes:
- Stops forcing
--idto be parsed as a string and updates validation to usevalidation.isValidPositiveInteger. - Updates the validation error message for invalid
--idvalues. - Adds additional validation tests for invalid numeric
idinputs (negative/float).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/m365/spo/commands/user/user-get.ts | Updates option typing and id validation logic to accept a positive integer ID passed via CLI. |
| src/m365/spo/commands/user/user-get.spec.ts | Adds extra validation test coverage for invalid id values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7458