Fix multi-geo SPO compatibility issues#5401
Merged
Merged
Conversation
Align Get-PnPGeoAdministrator response handling with SPO Management Shell by reading the GeoAdministrators endpoint as an OData feed. Remove the extra Set-PnPMultiGeoExperience ShouldProcess confirmation so it matches the SPO single irreversible-upgrade prompt, and align the allowed data location unsupported-version error message. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Multi-Geo behavior to better match the SPO Management Shell.
Changes:
- Corrects Geo Administrator feed deserialization and property ordering.
- Adjusts upgrade confirmation and unsupported-version reporting.
- Updates documentation and changelog.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
MultiGeoRestApiClient.cs |
Uses feed deserialization and consistent version reporting. |
GeoAdministrator.cs |
Reorders output properties. |
SetMultiGeoExperience.cs |
Removes the generic confirmation gate. |
GetGeoAdministrator.cs |
Writes feed results directly. |
Get-PnPGeoAdministrator.md |
Updates documented property order. |
CHANGELOG.md |
Records the fixes. |
Comment on lines
22
to
23
| var multiGeoRestApiClient = new MultiGeoRestApiClient(AdminContext); | ||
| multiGeoRestApiClient.EnsureGeoExperienceUpgradeSupported(); |
Keep normal Set-PnPMultiGeoExperience execution aligned with SPO Management Shell's single ShouldContinue prompt while preventing execution when -WhatIf is supplied. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Addressed the Set-PnPMultiGeoExperience review feedback in dd5be70. Normal execution still matches SPO Management Shell by using only the single irreversible-upgrade ShouldContinue prompt, while -WhatIf now returns before the support check/prompt/upgrade by calling ShouldProcess only for the WhatIf path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
Addresses feedback in #5103.
What is in this Pull Request ?
Fixes multi-geo compatibility issues reported against the SPO Management Shell behavior:
Get-PnPGeoAdministratorresults as an OData feed sovalue/array responses deserialize correctly.GeoAdministratoroutput property order with the SPO Management Shell type.ShouldProcessprompt fromSet-PnPMultiGeoExperience, leaving the single SPO-style irreversible-upgrade confirmation.Set-PnPMultiGeoCompanyAllowedDataLocationwith the rest of the MultiGeo client.