Make some classes serializable#2874
Open
Luna712 wants to merge 10 commits into
Open
Conversation
Luna712
changed the title
fire-light42
approved these changes
Jun 25, 2026
Contributor
Author
|
@fire-light42 I caught some issues when further testing the ControllerActivity change. This now does some changes to Jackson as well That shouldn't cause an issue and makes the output fully match. We shouldn't need to serialize those methods like that. And also fixed some things that were being serialized in kotlinx but not Jackson. I can change this if necessary though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces JsonProperty with SerialName only if it does not match the variable name, because in the case it would be the default and just makes it easier to migrate later on by removing what we can now.