Elixir 120 modernization#26
Open
eriknaslund wants to merge 3 commits into
Open
Conversation
- Using single quotes was deprecated since https://elixir.hexdocs.pm/1.17.0/changelog.html (released 2024-07). - In this case we want an actual string and not a charlist anyways.
- Pinned the variable as suggested by the compiler.
- Increased the minimum elixir version in mix.exs to 1.16 since that's when the argument order change happened. - Argument order changed in Elixir 1.16.0 which was released 2023-12. - The older argument-order version is scheduled for removal in Elixir 2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #25 for issue description.
If we're not comfortable with increasing the minimum required Elixir version to 1.16 we can leave out the last commit (fd280ae). Ideally it's included though, because it logs a deprecation warning.