Skip to content

Allow integers in wmin, wmax, tmin, tmax arguments#148

Merged
nvaytet merged 3 commits into
mainfrom
fix-wmin-wmax-dtype
Jul 21, 2026
Merged

Allow integers in wmin, wmax, tmin, tmax arguments#148
nvaytet merged 3 commits into
mainfrom
fix-wmin-wmax-dtype

Conversation

@nvaytet

@nvaytet nvaytet commented Jul 21, 2026

Copy link
Copy Markdown
Member

Fixes #147.

We also fix:

  • the case where optimization for a choppers cascade is used in combination with a limits on time or wavelength.
  • a bug where the initial frame distance for optimization by choppers was not the same as the source distance (it was always zero)

@nvaytet
nvaytet requested a review from jl-wynen July 21, 2026 08:35
@nvaytet nvaytet changed the title Allow integers in wmin, wmax, tmin, tmax arguments. Allow integers in wmin, wmax, tmin, tmax arguments Jul 21, 2026
@nvaytet nvaytet added bug Something isn't working and removed bug Something isn't working labels Jul 21, 2026
@jl-wynen

Copy link
Copy Markdown
Member

the case where optimization for a choppers cascade is used in combination with a limits on time or wavelength.

What was broken in this case?

@nvaytet

nvaytet commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

the case where optimization for a choppers cascade is used in combination with a limits on time or wavelength.

What was broken in this case?

The time and wavelength limits were simply ignored. See here: we were just taking the min and max of the data.

@nvaytet
nvaytet merged commit 1b21815 into main Jul 21, 2026
4 checks passed
@nvaytet
nvaytet deleted the fix-wmin-wmax-dtype branch July 21, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The wmin/wmax params of source no longer accept integers

2 participants