Expose is_secondary on StorageNodeDTO (v2 storage-nodes API)#1175
Open
boddumanohar wants to merge 1 commit into
Open
Expose is_secondary on StorageNodeDTO (v2 storage-nodes API)#1175boddumanohar wants to merge 1 commit into
boddumanohar wants to merge 1 commit into
Conversation
Passthrough of the existing model.is_secondary_node field, no behavior change. Needed by the simplyblock-operator's new load-aware primary node placement webhook to exclude secondary nodes from placement candidates (simplyblock/simplyblock-operator#<placement-pr>). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_secondarytoStorageNodeDTO(v2GET /storage-nodes/), a passthrough of the existingmodel.is_secondary_nodefield. No behavior change.secondary_node_id(a primary's pointer to its own secondary) — a secondary node's own record wasn't distinguishable via the API.Why
Needed by simplyblock-operator's new load-aware primary node placement webhook (companion branch:
feature/primary-node-placementin simplyblock-operator), which excludes secondary nodes from placement candidates when choosing the best primary node for a new volume at creation time.Test plan
pytest tests/unit/web/api/v2/test_storage_node_endpoints.py— 11 passedruff check simplyblock_web/api/v2/_dtos.py— clean🤖 Generated with Claude Code