Skip to content

[test]: select a field mapping - #8344

Merged
CarolineDenis merged 4 commits into
mainfrom
issue-8343
Jul 28, 2026
Merged

[test]: select a field mapping#8344
CarolineDenis merged 4 commits into
mainfrom
issue-8343

Conversation

@rijulpoudel

@rijulpoudel rijulpoudel commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Fixes #8343

Summary by CodeRabbit

  • Tests
    • Added coverage for selecting a data-mapping value.
    • Verifies the selected mapping path is updated correctly and changes are marked as pending.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@maxpatiiuk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a23cfd6b-5772-4488-9cf1-49ce1dce4810

📥 Commits

Reviewing files that changed from the base of the PR and between 18229a9 and 7932ac7.

📒 Files selected for processing (4)
  • specifyweb/frontend/js_src/lib/components/Errors/ErrorDialog.tsx
  • specifyweb/frontend/js_src/lib/components/SetupTool/setupResources.ts
  • specifyweb/frontend/js_src/lib/components/WbUtils/datasetVariants.tsx
  • specifyweb/frontend/js_src/lib/localization/utils/validateWeblate.ts
📝 Walkthrough

Walkthrough

Changes

Data Mapper reducer validation

Layer / File(s) Summary
Mapping selection reducer test
specifyweb/frontend/js_src/lib/components/WbPlanView/__tests__/mappingReducer.test.ts
Adds a Jest test that selects catalogNumber at line 0/index 0 and verifies mappingPath and changesMade.
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: adding a test for selecting a field mapping.
Linked Issues check ✅ Passed The new test aligns with #8343 by verifying field mapping selection in the WorkBench Data Mapper.
Out of Scope Changes check ✅ Passed The PR only adds a focused test for the reported mapper behavior and shows no unrelated changes.
Automatic Tests ✅ Passed The PR adds a Jest test file under tests that matches the repo’s testMatch pattern and exercises reducer behavior.
Testing Instructions ✅ Passed The added Jest test clearly targets WbPlanView’s mappingReducer ChangeSelectElementValueAction and verifies the expected state update.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8343

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-89

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=826

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-112

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING


@rijulpoudel

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit Full Review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@CarolineDenis
CarolineDenis merged commit 2cad604 into main Jul 28, 2026
17 checks passed
@CarolineDenis
CarolineDenis deleted the issue-8343 branch July 28, 2026 08:39
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

[test]: Select a field mapping in the WorkBench Data Mapper

2 participants