Fix outdated Tutorial_DiscordMERLIN.ipynb#1157
Open
ShreyasK06 wants to merge 1 commit into
Open
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directorySummary
Fixes #1127
This PR fixes
docs/WIP/Tutorial_DiscordMERLIN.ipynb, which was broken in several ways due to API changes and dependency updates since it was originally written. All changes are scoped strictly to the notebook file.Fix 1 —
core.preprocessnow returns 4 valuesUpdated every
T, M_T, Σ_T = core.preprocess(...)call to the correct 4-value unpack (T, M_T, Σ_T, T_subseq_isconstant = core.preprocess(...)), and threadedT_subseq_isconstantthrough_find_candidates,_get_approx_P, and_refine_candidatesso it is passed correctly tocore._massand_prescrump.Fix 2 — Dead dataset URLs replaced
https://zenodo.org/record/4276428/files/STUMPY_Basics_Taxi.csv?download=1).Fix 3 —
core._sliding_dot_productrenamedUpdated both call sites in
_find_candidatesand_refine_candidatesfromcore._sliding_dot_producttocore.sliding_dot_product.Fix 4 —
np.NINFremoved in NumPy 2.0Replaced all 8 runtime occurrences of
np.NINFacross_refine_candidates, the MP verification block,_discords, andstumpy_top_k_discordswith-np.inf. Occurrences in docstrings and comments were left untouched.Known issue — pending review discussion
The notebook still fails at
out = _discords(T, m, k=15)with:ValueError: could not broadcast input array from shape (1489,1489) into shape (1489,)
This is caused by
stumpy.scrump._prescrumpnow returning a 2D(l, k)array instead of the 1D(l,)shape_get_approx_Pexpects. Fix is pending maintainer input.