Add left and right notches to brick outline#583
Open
parthdagia05 wants to merge 1 commit into
Open
Conversation
… brick outline Signed-off-by: Parth Dagia <parth.24bcs10414@sst.scaler.com>
74b8d2e to
f7e7c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds interlocking notches to the brick outline (path2):
The left tab is excluded from the brick's width/height (otherwise connected bricks would be pushed apart) and reported separately as
leftNotchDepth, which the Path view uses as a gutter so the tab isn't clipped. The label is centred on the notch line.Both notches are off by default. Added a Storybook playground (argCount /argHeight / left+right toggles) to check alignment, and tests covering groove count, tab alignment, dimensions, label position, and path closure.