Skip to content

Add left and right notches to brick outline#583

Open
parthdagia05 wants to merge 1 commit into
developfrom
gsoc-2026/brick-right-notch
Open

Add left and right notches to brick outline#583
parthdagia05 wants to merge 1 commit into
developfrom
gsoc-2026/brick-right-notch

Conversation

@parthdagia05

Copy link
Copy Markdown
Member

Adds interlocking notches to the brick outline (path2):

  • Right edge - one concave semicircular groove per argument slot, each centred a fixed offset below its slot, so grooves stay aligned with the arguments regardless of their heights.
  • Left edge - a single convex tab where the brick plugs into its parent, aligned with the top right groove. Its radius is one stroke width smaller than the groove so the two seat together cleanly.

The left tab is excluded from the brick's width/height (otherwise connected bricks would be pushed apart) and reported separately as leftNotchDepth, which the Path view uses as a gutter so the tab isn't clipped. The label is centred on the notch line.

Both notches are off by default. Added a Storybook playground (argCount /argHeight / left+right toggles) to check alignment, and tests covering groove count, tab alignment, dimensions, label position, and path closure.

… brick outline

Signed-off-by: Parth Dagia <parth.24bcs10414@sst.scaler.com>
@parthdagia05 parthdagia05 force-pushed the gsoc-2026/brick-right-notch branch from 74b8d2e to f7e7c3d Compare June 13, 2026 07:11
@github-project-automation github-project-automation Bot moved this to 🧠 Planning in Music Blocks (v4) Jun 13, 2026
@parthdagia05 parthdagia05 added this to the GSoC 2026 Mid-term milestone Jun 13, 2026
@parthdagia05 parthdagia05 added the gsoc Prospective or confirmed task for GSoC label Jun 13, 2026
@parthdagia05 parthdagia05 requested a review from meganindya June 13, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsoc Prospective or confirmed task for GSoC

Projects

Status: 🧠 Planning

Development

Successfully merging this pull request may close these issues.

1 participant