fix(core): remove root-level logback.xml from runtime JAR (#109)#110
Open
dkasimovskiy wants to merge 2 commits into
Open
fix(core): remove root-level logback.xml from runtime JAR (#109)#110dkasimovskiy wants to merge 2 commits into
dkasimovskiy wants to merge 2 commits into
Conversation
tarantool-core shipped a main-scoped logback.xml in its published JAR. Logback auto-discovers logback.xml on the classpath as application-level config, so consumer apps (e.g. Spring Boot with logback-spring.xml) had their logging overridden by the SDK. A library must not configure the host's logging system. Test logging is unaffected: tarantool-shared-resources/logback-test.xml is already copied into every module's test-classes via the root pom. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tarantool-core shipped a main-scoped logback.xml in its published JAR. Logback auto-discovers logback.xml on the classpath as application-level config, so consumer apps (e.g. Spring Boot with logback-spring.xml) had their logging overridden by the SDK. A library must not configure the host's logging system.
Test logging is unaffected: tarantool-shared-resources/logback-test.xml is already copied into every module's test-classes via the root pom.
I haven't forgotten about:
Related issues:
Closes #109