migration: add namespace tag to catchup_ready_shard_count metric#10834
Open
tsurdilo wants to merge 1 commit into
Open
migration: add namespace tag to catchup_ready_shard_count metric#10834tsurdilo wants to merge 1 commit into
tsurdilo wants to merge 1 commit into
Conversation
handover_ready_shard_count already emits a namespace tag; catchup_ready_shard_count was missing it, making it impossible to filter by namespace in dashboards when monitoring multiple global namespaces. The Namespace field is already present on WaitReplicationRequest and populated by the caller. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10833
What changed?
Add metrics.NamespaceTag to the catchup_ready_shard_count gauge emit in checkReplicationOnce.
Why?
handover_ready_shard_count already carries a namespace tag (same file, checkHandoverOnce). catchup_ready_shard_count was missing it, making it impossible to filter by namespace in dashboards when monitoring multiple global namespaces. The Namespace field already exists on WaitReplicationRequest and is populated by the caller.
How did you test it?
Potential risks
none to my knowledge