Add personal access tokens, deployment management, storage profiles and remove MySQL#36
Open
krishna-santosh wants to merge 46 commits into
Open
Add personal access tokens, deployment management, storage profiles and remove MySQL#36krishna-santosh wants to merge 46 commits into
krishna-santosh wants to merge 46 commits into
Conversation
New migration creating tables for personal access tokens, deployments (triggers/jobs), and storage profiles across all three backends.
Replace simple read/write permission model with fine-grained TokenScope enum supporting site, content, files, schema, webhooks, deployments, and MCP scopes. Add PersonalAccessToken types, encode/decode helpers, and backward-compatible 'read'/'write' aliases. Update authorization model with new Action variants (WebhooksTrigger, Deployments*) and token_hard_denied helper. Extend repository traits with personal token storage interface and implement across all three backends.
…ment Introduce PersonalTokenActor with scope-based auth enforcement. Support vcms_pat_ token prefix in API auth middleware. Resolve personal token site context via X-VCMS-Site header. Add PAT CRUD (create/list/revoke) service, handler, and /account/tokens routes. Update GraphQL context to pass requested site and scopes. Provide in-memory PAT repository stubs for testing.
Register deployment and storage_profile modules in lib.rs and services. Add deployment and storage profile routes in router. Wire storage profile registration and deployment reconcilation at server startup. Add storage_profile_id to CLI backup create options.
Introduce StorageProfile model, service (CRUD + probe), and HTTP handler. Add storage_profile_id optional column to Site model and include it in all site queries across backends. Assign storage profile on site creation. Expose profile ID in site listing responses. Wire storage profile CRUD and probe routes under /instance/storage-profiles. Update file storage resolution to COALESCE storage profile over legacy storage_provider.
Add DestinationSpec::Profile variant for routing backups through configured storage profiles. Include storage_profile_id in backup and schedule creation payloads. Persist profile ID in backup metadata tables.
Add DeploymentTrigger and DeploymentJob models, service with reconcile_interrupted for crash recovery, HTTP handler, and routes under /sites/{site_id}/deployments. Extend WebhookService with protect/reveal_deployment_config helpers for encrypting deployment URL and headers.
Add list_sites tool returning sites accessible to the authenticated user. Enforce that all site-scoped MCP tools require an explicit site_id parameter (except list_sites). Clean up whitespace (CRLF→LF) and update test assertions to match.
Add API functions and TypeScript types for scoped site tokens, personal access tokens (PAT), storage profiles (CRUD + probe), deployments (triggers, jobs, history), and storage_profile_id on backups and sites.
Add PersonalTokensCard component for creating, listing, and revoking personal access tokens. Integrate into the account page.
…ge profiles Rebuild storage settings page with storage profile CRUD (create, list, probe, delete). Add storage profile picker to the create-site dialog. Require operator role instead of instance_owner only.
…authorization service Pass X-VCMS-Site header from GraphQL router to GqlContext for personal token site resolution. Update AuthorizationService to use scope_for_action and PersonalTokenActor for scope-based enforcement.
…backup selector, and update routing Add deployments management page under site settings. Add MCP configuration page. Add storage profile selector to backup creation form. Update sidebar with new navigation items. Regenerate route tree. Pass role prop to GeneralSection. Update site settings layout and routing.
…ment jobs Add partial unique index on deployment_jobs to enforce at most one queued or running job per trigger. MySQL uses a generated column approach, Postgres and SQLite use filtered unique indexes.
…oyment service Extract build_protected_client from deliver_to_url as a reusable method for deployments. Refactor deployment execute_job to use it. Add map_job_insert_error returning 'deployment_in_progress' on unique violation and a unit test for active job uniqueness.
…ns in GraphQL When a personal token supplies X-VCMS-Site, verify the user has SiteRead access before trusting the header, rather than blindly accepting the requested site.
Swap 'now' and 'storage_profile_id' parameter positions in insert_running and create_schedule to match the actual column order in the backups and backup_schedules tables.
…CT, and indexes Add ENGINE=InnoDB to storage_profiles CREATE TABLE, add ON DELETE RESTRICT to backup FKs, and add standalone indexes for backup FK columns.
…require_scope Add TokenScopes to GrpcAuthContext, decode scopes from access token HMAC payload, determine can_write from any write-scope presence, and replace coarse can_read/require_read/require_write with require_scope(TokenScope).
Replace require_read()/require_write() calls with require_scope(TokenScope::*) across all gRPC service implementations to enforce fine-grained token scopes.
Introduce site_key_scopes() helper that returns the full scope list for read or write access, and update create_site_and_token to accept a scopes array instead of a permission string.
Switch gRPC test token creation from the 'permission' field to the 'scopes' field using site_key_scopes.
Replace the 'permission' field with 'scopes' using site_key_scopes in all GraphQL integration tests.
Replace the 'permission' field with 'scopes' using site_key_scopes in all REST integration tests. Update assertions to check for scopes presence instead of the permission string.
Add mcp_call_site_tool wrapper that injects site_id into tool call arguments, and update create_test_collection/create_test_entry fixtures to accept a site_id parameter.
Update all MCP integration tests to use mcp_call_site_tool instead of bare mcp_call_tool, passing the captured site_id so that tools receive the required site_id argument.
Replace references to vcms_site_* tokens with generic 'VCMS access token' in doc comments, reflecting that vcms_pat_* tokens are now also accepted.
Update MCP proxy section to describe that both vcms_site_* and vcms_pat_* tokens with the mcp.use scope are accepted.
Change error assertion from 'MCP requires a vcms_site_* access token' to 'MCP requires a VCMS access token', consistent with vcms_pat_* token support.
Flip test assertion from expecting list_sites to be absent to expecting it to be available, reflecting the new list_sites tool.
|
Important Review skippedToo many files! This PR contains 125 files, which is 25 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (143)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.