Skip to content

fix: use href carry no-inline query#491

Open
btea wants to merge 4 commits into
vitejs:mainfrom
btea:fix/svg-use-import-svg-carry-no-inline-query
Open

fix: use href carry no-inline query#491
btea wants to merge 4 commits into
vitejs:mainfrom
btea:fix/svg-use-import-svg-carry-no-inline-query

Conversation

@btea

@btea btea commented Dec 16, 2024

Copy link
Copy Markdown
Contributor

Description

fix #490

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pkg-pr-new

pkg-pr-new Bot commented Dec 16, 2024

Copy link
Copy Markdown

Open in Stackblitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@491
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@491

commit: e7345e2

@sapphi-red

Copy link
Copy Markdown
Member

I think instead of adding ?no-inline automatically, we need to tell @vue/compiler-sfc not to strip the queries and hashes (not sure if @vue/compiler-sfc is doing that). Otherwise, <img src="./foo.svg?inline"> or <img src="./foo.png?no-inline"> won't work as users expect.

@btea

btea commented Dec 17, 2024

Copy link
Copy Markdown
Contributor Author

No relevant configuration is found.

@btea btea marked this pull request as draft December 17, 2024 13:34
@btea

btea commented Dec 20, 2024

Copy link
Copy Markdown
Contributor Author

I haven't been able to find the relevant configuration.

Currently, it will only add ?no-inline to the href attribute of the use tag(it seems that only the use tag cannot directly load the data URIs link), which should not affect the processing of the img tag.

I haven't been able to find a better way, and would appreciate your suggestions.

@btea btea marked this pull request as ready for review December 20, 2024 13:07
@sapphi-red

Copy link
Copy Markdown
Member

Adding ?no-inline automatically for <use> in plugin-vue makes sense to me.

That said, if there isn't an option in @vue/compiler-sfc, I think that needs to be added to support other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformAssetUrls strips all queries and breaks SVG sprites

2 participants