esp: check ll send return value.#145
Open
philljj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ESP transmit path to handle the return value from the link-layer send() callback, aiming to avoid silently ignoring TX failures.
Changes:
- Capture and check the return value of
ll_dev->send()inesp_send().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1871
to
+1876
| esp_rc = ll_dev->send(ll_dev, esp, ip_final_len + ETH_HEADER_LEN); | ||
| if (esp_rc != (ip_final_len + ETH_HEADER_LEN)) { | ||
| ESP_LOG("error: esp dev send: sent %d, expected %d\n", esp_rc, | ||
| (ip_final_len + ETH_HEADER_LEN)); | ||
| return -1; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing return value check for
ll_dev->send(inesp.c.Testing